Skip to content

ci: Fix flake8 error in format_pre#18825

Merged
htuch merged 1 commit intoenvoyproxy:mainfrom
phlax:flake8-fix
Oct 29, 2021
Merged

ci: Fix flake8 error in format_pre#18825
htuch merged 1 commit intoenvoyproxy:mainfrom
phlax:flake8-fix

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Oct 29, 2021

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:

Fixes issue discussed here #18817 (comment)

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 29, 2021
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @wrowe

🐱

Caused by: #18825 was opened by phlax.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Oct 29, 2021

the problem was in the pytooling code, upstream resolution was here:

envoyproxy/toolshed#108

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 29, 2021
@htuch htuch enabled auto-merge (squash) October 29, 2021 18:27
@htuch htuch merged commit 136e11d into envoyproxy:main Oct 29, 2021
jasonmillerstackpath pushed a commit to jasonmillerstackpath/envoy that referenced this pull request Oct 29, 2021
Fixes issue discussed here envoyproxy#18817 (comment)

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants